Dennis-Mircea commented on code in PR #1170:
URL:
https://github.com/apache/flink-kubernetes-operator/pull/1170#discussion_r3730225396
##########
docs/content.zh/docs/operations/logging.md:
##########
@@ -115,10 +115,10 @@ Logback XML overrides replace the entire default
configuration. Unlike Log4j2 `.
## Logging Library Version Overrides
-The operator ships with Logback 1.2.x and SLF4J 1.7.x. These versions are
bundled in the Docker image and the SLF4J 1.7.x API is shaded into the operator
JAR.
+The operator ships with Logback 1.5.x and SLF4J 2.0.x. These versions are
bundled in the Docker image and the SLF4J 2.0.x API is shaded into the operator
JAR.
{{< hint warning >}}
-Upgrading to Logback 1.4+/1.5+ or SLF4J 2.x is not supported. SLF4J 2.x uses a
`ServiceLoader`-based binding mechanism that is incompatible with the SLF4J
1.7.x API shaded inside the operator. Replacing the JARs at runtime will result
in `ClassNotFoundException: org.slf4j.impl.StaticLoggerBinder`.
+Downgrading to Logback 1.2.x or SLF4J 1.7.x is not supported. SLF4J 2.x
locates the backend through a `ServiceLoader`
(`org.slf4j.spi.SLF4JServiceProvider`), whereas Logback 1.2.x provides the
older `org.slf4j.impl.StaticLoggerBinder`, which SLF4J 2.x ignores. Replacing
the JARs at runtime does not raise an error: SLF4J falls back to a no-operation
logger and all log output is silently discarded.
{{< /hint >}}
Review Comment:
I'd remove entirely this hint, as the logging library downgrade should not
be something performed by the users.
##########
flink-kubernetes-operator/pom.xml:
##########
@@ -164,6 +165,13 @@ under the License.
<scope>provided</scope>
</dependency>
+ <dependency>
+ <groupId>ch.qos.logback</groupId>
+ <artifactId>logback-core</artifactId>
Review Comment:
Is this actually needed, or is it redundant with the
`maven-dependency-plugin` artifactItem?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
