[
https://issues.apache.org/jira/browse/FLINK-5767?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15880287#comment-15880287
]
ASF GitHub Bot commented on FLINK-5767:
---------------------------------------
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/3354#discussion_r102692834
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/functions/aggfunctions/AvgAggFunction.scala
---
@@ -28,8 +28,9 @@ import org.apache.flink.table.functions.{Accumulator,
AggregateFunction}
* @tparam T the type for the aggregation result
*/
abstract class IntegralAvgAggFunction[T] extends AggregateFunction[T] {
+
/** The initial accumulator for Integral Avg aggregate function */
- class IntegralAvgAccumulator extends Accumulator {
+ class IntegralAvgAccumulator extends JTuple2[Long, Long] with
Accumulator {
--- End diff --
If you are using a `JTuple` you may not add additional fields but should
use the Tuple2 fields (`f0` and `f1`).
Since the `TupleSerializer` is not aware of the added fields,
`IntegralAvgAccumulator` won't be treated as Tuple2 by Flink.
> New aggregate function interface and built-in aggregate functions
> -----------------------------------------------------------------
>
> Key: FLINK-5767
> URL: https://issues.apache.org/jira/browse/FLINK-5767
> Project: Flink
> Issue Type: Sub-task
> Components: Table API & SQL
> Reporter: Shaoxuan Wang
> Assignee: Shaoxuan Wang
>
> Add a new aggregate function interface. This includes implementing the
> aggregate interface, migrating the existing aggregation functions to this
> interface, and adding the unit tests for these functions.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
