[
https://issues.apache.org/jira/browse/FLINK-5767?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15880288#comment-15880288
]
ASF GitHub Bot commented on FLINK-5767:
---------------------------------------
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/3354#discussion_r102693561
--- Diff:
flink-libraries/flink-table/src/test/scala/org/apache/flink/table/functions/aggfunctions/AggFunctionTestBase.scala
---
@@ -56,11 +53,15 @@ abstract class AggFunctionTestBase[T] {
if (ifMethodExitInFunction("merge", aggregator)) {
// iterate over input sets
- for((vals, expected) <- inputValueSets.zip(expectedResults)) {
+ for ((vals, expected) <- inputValueSets.zip(expectedResults)) {
val (firstVals, secondVals) = vals.splitAt(vals.length / 2)
--- End diff --
In addition to splitting the `vals` data set, we should also test
correctness, if we merge with an empty accumulator, i.e., aggregate all `vals`
into one accumulator and merge it with an empty one.
> New aggregate function interface and built-in aggregate functions
> -----------------------------------------------------------------
>
> Key: FLINK-5767
> URL: https://issues.apache.org/jira/browse/FLINK-5767
> Project: Flink
> Issue Type: Sub-task
> Components: Table API & SQL
> Reporter: Shaoxuan Wang
> Assignee: Shaoxuan Wang
>
> Add a new aggregate function interface. This includes implementing the
> aggregate interface, migrating the existing aggregation functions to this
> interface, and adding the unit tests for these functions.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
