[
https://issues.apache.org/jira/browse/GEODE-8666?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17221873#comment-17221873
]
ASF GitHub Bot commented on GEODE-8666:
---------------------------------------
moleske opened a new pull request #680:
URL: https://github.com/apache/geode-native/pull/680
Authored-by: M. Oleske <michael@oleske.engineer>
tagging @gaussianrecurrence & @mreddington if you'd like to review also
Passing tests
[Ubuntu - clang, units, integration, acceptance,
ipv6](https://github.com/moleske/geode-native/actions/runs/332211481)
[Mac - units, integration,
acceptance](https://github.com/moleske/geode-native/actions/runs/332211479)
[Windows units, integration, acceptance (cli and
cpp)](https://github.com/moleske/geode-native/actions/runs/332211482)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Enforce warning no-non-virtual-dtor
> -----------------------------------
>
> Key: GEODE-8666
> URL: https://issues.apache.org/jira/browse/GEODE-8666
> Project: Geode
> Issue Type: Improvement
> Components: native client
> Reporter: Michael Oleske
> Priority: Major
>
> Given I compile the code without exempting no-non-virtual-dtor
> Then it should compile
> Note - was marked as a todo
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
