[
https://issues.apache.org/jira/browse/GEODE-8666?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17221977#comment-17221977
]
ASF GitHub Bot commented on GEODE-8666:
---------------------------------------
pivotal-jbarrett commented on a change in pull request #680:
URL: https://github.com/apache/geode-native/pull/680#discussion_r513209098
##########
File path: cppcache/include/geode/CqQuery.hpp
##########
@@ -53,6 +53,8 @@ class Query;
*/
class APACHE_GEODE_EXPORT CqQuery {
public:
+ virtual ~CqQuery() = default;
Review comment:
This will for sure change the ABI. I am not sure we can do this on the
public headers until the next major.
##########
File path: cppcache/include/geode/AuthenticatedView.hpp
##########
@@ -90,7 +90,7 @@ class APACHE_GEODE_EXPORT AuthenticatedView : public
RegionService {
/**
* @brief destructor
*/
- virtual ~AuthenticatedView();
+ virtual ~AuthenticatedView() override;
Review comment:
`virtual` is redundant when `override` is specified. Under some
analyzers it will warn or error about it.
##########
File path: cppcache/include/geode/AuthenticatedView.hpp
##########
@@ -90,7 +90,7 @@ class APACHE_GEODE_EXPORT AuthenticatedView : public
RegionService {
/**
* @brief destructor
*/
- virtual ~AuthenticatedView();
+ virtual ~AuthenticatedView() override;
Review comment:
Given that this is a public header, what impact is there to the ABI?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Enforce warning no-non-virtual-dtor
> -----------------------------------
>
> Key: GEODE-8666
> URL: https://issues.apache.org/jira/browse/GEODE-8666
> Project: Geode
> Issue Type: Improvement
> Components: native client
> Reporter: Michael Oleske
> Priority: Major
> Labels: pull-request-available
>
> Given I compile the code without exempting no-non-virtual-dtor
> Then it should compile
> Note - was marked as a todo
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
