[
https://issues.apache.org/jira/browse/GEODE-8666?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17222624#comment-17222624
]
ASF GitHub Bot commented on GEODE-8666:
---------------------------------------
moleske commented on pull request #680:
URL: https://github.com/apache/geode-native/pull/680#issuecomment-718276637
Ugh ABI. I never think about it cause it's not in my head part of the
contract for breaking changes (just API changes). I'll close this after
@gaussianrecurrence reports back with any learnings from why the ABI compliance
tool says it is fine (when I also agree it is not). Will also update the JIRA
story to reflect that it can't be done yet
Tangential question, what version is native client now? Geode server is at
1.13 but is that what native client is? So to release a major version of
native client we need to wait til Geode makes a 2.0 release? That seems not
great. I've never understood why geode native and geode are release with the
same versioning scheme...
Also, another tangential question, why are we saying ABI breakage requires a
major version change? Might be worth writing that down somewhere (unless it is
already in the wiki, which I never check). Assuming because it requires
consumers of geode native to recompile, but are there other reasons?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Enforce warning no-non-virtual-dtor
> -----------------------------------
>
> Key: GEODE-8666
> URL: https://issues.apache.org/jira/browse/GEODE-8666
> Project: Geode
> Issue Type: Improvement
> Components: native client
> Reporter: Michael Oleske
> Priority: Major
> Labels: pull-request-available
>
> Given I compile the code without exempting no-non-virtual-dtor
> Then it should compile
> Note - was marked as a todo
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
