[
https://issues.apache.org/jira/browse/GEODE-8666?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17222185#comment-17222185
]
ASF GitHub Bot commented on GEODE-8666:
---------------------------------------
gaussianrecurrence commented on a change in pull request #680:
URL: https://github.com/apache/geode-native/pull/680#discussion_r513466788
##########
File path: cppcache/include/geode/AuthenticatedView.hpp
##########
@@ -90,7 +90,7 @@ class APACHE_GEODE_EXPORT AuthenticatedView : public
RegionService {
/**
* @brief destructor
*/
- virtual ~AuthenticatedView();
+ virtual ~AuthenticatedView() override;
Review comment:
In this case the change is not breaking ABI BC as override is just a
keyword introduced in the standard in order to have the compiler checked that
the virtual function you are overriding has the same signature as the one on
the base class.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Enforce warning no-non-virtual-dtor
> -----------------------------------
>
> Key: GEODE-8666
> URL: https://issues.apache.org/jira/browse/GEODE-8666
> Project: Geode
> Issue Type: Improvement
> Components: native client
> Reporter: Michael Oleske
> Priority: Major
> Labels: pull-request-available
>
> Given I compile the code without exempting no-non-virtual-dtor
> Then it should compile
> Note - was marked as a todo
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
