[
https://issues.apache.org/jira/browse/GEODE-852?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15119826#comment-15119826
]
ASF GitHub Bot commented on GEODE-852:
--------------------------------------
GitHub user jinmeiliao opened a pull request:
https://github.com/apache/incubator-geode/pull/80
GEODE-852: refactor gemfire-pulse not to generate a pulseverion.prope…
…rties file but copy it from gemfire-core
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/jinmeiliao/incubator-geode feature/GEODE-852
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-geode/pull/80.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #80
----
commit a1b922c97e076553c95693d5e4cf223df9be4bfb
Author: Jinmei Liao <jil...@pivotal.io>
Date: 2016-01-27T17:18:35Z
GEODE-852: refactor gemfire-pulse not to generate a pulseverion.properties
file but copy it from gemfire-core
----
> (Re)move pulseversion.properties file
> -------------------------------------
>
> Key: GEODE-852
> URL: https://issues.apache.org/jira/browse/GEODE-852
> Project: Geode
> Issue Type: Improvement
> Components: management
> Reporter: Anthony Baker
>
> Currently the pulse build is creating the file
> gemfire-pulse/src/main/resources/pulseversion.properties. I have a few
> observations:
> 1) We should always create generated files in the generated-* directory. For
> example:
> gemfire-core/build/generated-resources/main/com/gemstone/gemfire/internal/GemFireVersion.properties
> This means we can remove the exclusion from rat.gradle.
> 2) We already create GemFireVersion.properties. Can pulse use that file
> instead? If not, we should at least merge the common code to create these
> files (see gemfire-core/build.gradle).
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
