[ https://issues.apache.org/jira/browse/GEODE-852?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15129267#comment-15129267 ]
ASF subversion and git services commented on GEODE-852: ------------------------------------------------------- Commit 4113eec91d9dd41d460af5b5d215f67ff9d4e618 in incubator-geode's branch refs/heads/develop from [~upthewaterspout] [ https://git-wip-us.apache.org/repos/asf?p=incubator-geode.git;h=4113eec ] GEODE-852: Tweak to how we copy the pulse version properties file The old way was forcing a compilation of gemfire-core in order to generate the properties. Using a task as the input to the copy automatically adds the task as a dependency of the copy and the outputs of the task as the list of files to copy. > (Re)move pulseversion.properties file > ------------------------------------- > > Key: GEODE-852 > URL: https://issues.apache.org/jira/browse/GEODE-852 > Project: Geode > Issue Type: Improvement > Components: management > Reporter: Anthony Baker > Assignee: Jinmei Liao > Fix For: 1.0.0-incubating.M2 > > > Currently the pulse build is creating the file > gemfire-pulse/src/main/resources/pulseversion.properties. I have a few > observations: > 1) We should always create generated files in the generated-* directory. For > example: > gemfire-core/build/generated-resources/main/com/gemstone/gemfire/internal/GemFireVersion.properties > This means we can remove the exclusion from rat.gradle. > 2) We already create GemFireVersion.properties. Can pulse use that file > instead? If not, we should at least merge the common code to create these > files (see gemfire-core/build.gradle). -- This message was sent by Atlassian JIRA (v6.3.4#6332)