[ https://issues.apache.org/jira/browse/GEODE-852?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15119843#comment-15119843 ]
ASF GitHub Bot commented on GEODE-852: -------------------------------------- Github user nitin-amp commented on a diff in the pull request: https://github.com/apache/incubator-geode/pull/80#discussion_r51018580 --- Diff: gemfire-pulse/src/main/java/com/vmware/gemfire/tools/pulse/internal/data/PulseConstants.java --- @@ -38,7 +38,7 @@ // Pulse version details properties from properties file public static final String PULSE_VERSION_PROPERTIES_FILE = "pulseversion.properties"; --- End diff -- Should this String change to 'GemFireVersion.properties'? > (Re)move pulseversion.properties file > ------------------------------------- > > Key: GEODE-852 > URL: https://issues.apache.org/jira/browse/GEODE-852 > Project: Geode > Issue Type: Improvement > Components: management > Reporter: Anthony Baker > Assignee: Jinmei Liao > > Currently the pulse build is creating the file > gemfire-pulse/src/main/resources/pulseversion.properties. I have a few > observations: > 1) We should always create generated files in the generated-* directory. For > example: > gemfire-core/build/generated-resources/main/com/gemstone/gemfire/internal/GemFireVersion.properties > This means we can remove the exclusion from rat.gradle. > 2) We already create GemFireVersion.properties. Can pulse use that file > instead? If not, we should at least merge the common code to create these > files (see gemfire-core/build.gradle). -- This message was sent by Atlassian JIRA (v6.3.4#6332)