[
https://issues.apache.org/jira/browse/GEODE-852?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15119928#comment-15119928
]
ASF GitHub Bot commented on GEODE-852:
--------------------------------------
Github user upthewaterspout commented on the pull request:
https://github.com/apache/incubator-geode/pull/80#issuecomment-175780734
Looks good! One minor point - I think this is missing something that will
tell gradle what the copyPulsePropFile task depends on. You could either add a
dependsOn to the task, or maybe add an inputs.dir to the task:
inputs.dir project(':gemfire-core').sourceSets.main.output
Try running
/gradlew gemfire-pulse:copyPulsePropFile
or
/gradlew gemfire-pulse:war
and you'll see what I mean; it won't generate the original properties file.
> (Re)move pulseversion.properties file
> -------------------------------------
>
> Key: GEODE-852
> URL: https://issues.apache.org/jira/browse/GEODE-852
> Project: Geode
> Issue Type: Improvement
> Components: management
> Reporter: Anthony Baker
> Assignee: Jinmei Liao
>
> Currently the pulse build is creating the file
> gemfire-pulse/src/main/resources/pulseversion.properties. I have a few
> observations:
> 1) We should always create generated files in the generated-* directory. For
> example:
> gemfire-core/build/generated-resources/main/com/gemstone/gemfire/internal/GemFireVersion.properties
> This means we can remove the exclusion from rat.gradle.
> 2) We already create GemFireVersion.properties. Can pulse use that file
> instead? If not, we should at least merge the common code to create these
> files (see gemfire-core/build.gradle).
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
