[
https://issues.apache.org/jira/browse/HBASE-15406?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15316143#comment-15316143
]
Heng Chen commented on HBASE-15406:
-----------------------------------
{quote}
When admin / HBCK puts the master in maintenance mode, she can optionally
supply an ephemeral znode path that the master will watch. As soon as all
ephemeral nodes goes away, master will go out of maintenance mode. Every
instance of HBCK creates an ephemeral znode, so that even more than one
instance is running, there won't be issues if one finishes, while the others
are going. wdyt?
{quote}
[~enis] Have you see comments of [~stack] above.
{quote}
To be more clear, -1 on a patch that has master doing a rollback of a state set
by external administrator's tool. HBCK already leaves the cluster in a state of
disequilibrium when killed mid-processing... Usual way this is addressed is
HBCK gets rerun... not master does cleanup.
{quote}
The first patch is creating ephemeral node when hbck running and master do
watch it. When hbck abort, master will rollback the state. But as [~stack]
comments, "Usual way is HBCK gets rerun, not master cleanup".
> Split / merge switch left disabled after early termination of hbck
> ------------------------------------------------------------------
>
> Key: HBASE-15406
> URL: https://issues.apache.org/jira/browse/HBASE-15406
> Project: HBase
> Issue Type: Bug
> Reporter: Ted Yu
> Assignee: Heng Chen
> Priority: Critical
> Labels: reviewed
> Fix For: 2.0.0, 1.3.0, 1.4.0
>
> Attachments: HBASE-15406.patch, HBASE-15406.v1.patch,
> HBASE-15406_v1.patch, HBASE-15406_v2.patch, test.patch, wip.patch
>
>
> This was what I did on cluster with 1.4.0-SNAPSHOT built Thursday:
> Run 'hbase hbck -disableSplitAndMerge' on gateway node of the cluster
> Terminate hbck early
> Enter hbase shell where I observed:
> {code}
> hbase(main):001:0> splitormerge_enabled 'SPLIT'
> false
> 0 row(s) in 0.3280 seconds
> hbase(main):002:0> splitormerge_enabled 'MERGE'
> false
> 0 row(s) in 0.0070 seconds
> {code}
> Expectation is that the split / merge switches should be restored to default
> value after hbck exits.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
