[ https://issues.apache.org/jira/browse/HBASE-15406?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15319886#comment-15319886 ]
Heng Chen commented on HBASE-15406: ----------------------------------- Agree. We should have one framework to do this things. In current patch, we cleanup the lock and rollback the state by HBCK, so it makes the logic much more complex than master do this work. {quote} One idea that he was proposing is to re-purpose the HBCK lock into being a znode lock, and have the CJ, Balancer and Split/Merge look into whether HBCK is running or not. I think this will be much simpler than adding 3 "advanced" APIs to Admin. wdyt? {quote} Who will rollback the state and cleanup lock if hbck abort, Master or hbck ? > Split / merge switch left disabled after early termination of hbck > ------------------------------------------------------------------ > > Key: HBASE-15406 > URL: https://issues.apache.org/jira/browse/HBASE-15406 > Project: HBase > Issue Type: Bug > Reporter: Ted Yu > Assignee: Heng Chen > Priority: Critical > Labels: reviewed > Fix For: 2.0.0, 1.3.0, 1.4.0 > > Attachments: HBASE-15406.patch, HBASE-15406.v1.patch, > HBASE-15406_v1.patch, HBASE-15406_v2.patch, test.patch, wip.patch > > > This was what I did on cluster with 1.4.0-SNAPSHOT built Thursday: > Run 'hbase hbck -disableSplitAndMerge' on gateway node of the cluster > Terminate hbck early > Enter hbase shell where I observed: > {code} > hbase(main):001:0> splitormerge_enabled 'SPLIT' > false > 0 row(s) in 0.3280 seconds > hbase(main):002:0> splitormerge_enabled 'MERGE' > false > 0 row(s) in 0.0070 seconds > {code} > Expectation is that the split / merge switches should be restored to default > value after hbck exits. -- This message was sent by Atlassian JIRA (v6.3.4#6332)