[ 
https://issues.apache.org/jira/browse/HBASE-24280?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17095878#comment-17095878
 ] 

Michael Stack commented on HBASE-24280:
---------------------------------------

So, this patch is not fit given hbase-personality is used on all branches as 
Nick points out up above ? (master doesn't have the hadoop.version property).

Looking at master, it is trying to do profile AND property -- -P and -D -- but 
I'm not sure that activation stuff works for profiles.

     <profile>
       <id>hadoop-3.0</id>
       <activation>
         <property><name>!hadoop.profile</name></property>
       </activation>
       <properties>

... 

Thinking on what this issue has turned up, let me go back to HBASE-24215. I'm 
now of the opinion that the (painful) 'fix' there actually would not be needed 
if we didn't have both hadoop2 and hadoop3 profiles activated as you found here 
(no wonder I was having trouble repro'ing what was happening up on jenkins).

Takes a village...

> TestSecureRESTServer started failing in nightlies for Hadoop3
> -------------------------------------------------------------
>
>                 Key: HBASE-24280
>                 URL: https://issues.apache.org/jira/browse/HBASE-24280
>             Project: HBase
>          Issue Type: Bug
>            Reporter: Josh Elser
>            Assignee: Istvan Toth
>            Priority: Major
>             Fix For: 2.3.0
>
>         Attachments: HBASE-24280.master.001.patch, 
> TEST-org.apache.hadoop.hbase.rest.TestSecureRESTServer.xml
>
>
> [~ndimiduk] pointed out that, after this change went in, TestSecureRESTServer 
> started failing with Hadoop3 on branch-2.3
> https://builds.apache.org/job/HBase%20Nightly/job/branch-2.3/56/
> Of course, I ran this with 1.8.0_241 and Maven 3.6.33 and it passed :) {{mvn 
> clean package -Dtest=TestSecureRESTServer -Dhadoop.profile=3.0 
> -DfailIfNoTests=false}}
> FYI [~stoty] in case you can repro a failure and want to dig in. Feel free to 
> re-assign.
> It looks like we didn't have a nightly run of branch-2.2 due to docker 
> container build issues. Will be interesting to see if it fails there. It did 
> not fail the master nightly.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to