[
https://issues.apache.org/jira/browse/HBASE-24280?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17096687#comment-17096687
]
Josh Elser commented on HBASE-24280:
------------------------------------
{quote}Set <activeByDefault> on the hadoop3 profile
{quote}
My only worry is that activeByDefault does _not_ work how we want it to work.
At least, in all of my previous go's at maven profiles, that's how I've found
it. activeByDefault only works when you have no other profile activation
explicitly provided.
Some context in: https://issues.apache.org/jira/browse/MNG-3229 and
https://issues.apache.org/jira/browse/MNG-3229
This is the big reason we use the absence of a system property to activate a
profile, not by using activeByDefault. Looking at master today, a dirt-simple
thing doesn't even work.
{code:java}
diff --git a/pom.xml b/pom.xml
index 729ba92440..6af43c3abb 100755
--- a/pom.xml
+++ b/pom.xml
@@ -3535,6 +3535,12 @@
</os>
</activation>
</profile>
+ <profile>
+ <id>jelser-test-active</id>
+ <activation>
+ <activeByDefault>true</activeByDefault>
+ </activation>
+ </profile>
</profiles>
<!-- See https://jira.codehaus.org/browse/MSITE-443 why the settings need to
be here and not in pluginManagement. -->
<reporting>{code}
{noformat}
% mvn help:active-profiles
...
[INFO] -----------------------< org.apache.hbase:hbase >-----------------------
[INFO] Building Apache HBase 3.0.0-SNAPSHOT [1/41]
[INFO] --------------------------------[ pom ]---------------------------------
[INFO]
[INFO] --- maven-help-plugin:3.2.0:active-profiles (default-cli) @ hbase ---
[INFO]
Active Profiles for Project 'org.apache.hbase:hbase:pom:3.0.0-SNAPSHOT':
The following profiles are active:
- build-with-jdk8 (source: org.apache.hbase:hbase:3.0.0-SNAPSHOT)
- os.mac (source: org.apache.hbase:hbase:3.0.0-SNAPSHOT)
- hadoop-3.0 (source: org.apache.hbase:hbase:3.0.0-SNAPSHOT)
{noformat}
That all said, I think we are all in favor of clarity and conciseness in how we
build HBase. Let's just discern quality of life from "directly busted" which is
what we have now :)
> TestSecureRESTServer started failing in nightlies for Hadoop3
> -------------------------------------------------------------
>
> Key: HBASE-24280
> URL: https://issues.apache.org/jira/browse/HBASE-24280
> Project: HBase
> Issue Type: Bug
> Reporter: Josh Elser
> Assignee: Istvan Toth
> Priority: Major
> Fix For: 2.3.0
>
> Attachments: HBASE-24280.master.001.patch,
> TEST-org.apache.hadoop.hbase.rest.TestSecureRESTServer.xml
>
>
> [~ndimiduk] pointed out that, after this change went in, TestSecureRESTServer
> started failing with Hadoop3 on branch-2.3
> https://builds.apache.org/job/HBase%20Nightly/job/branch-2.3/56/
> Of course, I ran this with 1.8.0_241 and Maven 3.6.33 and it passed :) {{mvn
> clean package -Dtest=TestSecureRESTServer -Dhadoop.profile=3.0
> -DfailIfNoTests=false}}
> FYI [~stoty] in case you can repro a failure and want to dig in. Feel free to
> re-assign.
> It looks like we didn't have a nightly run of branch-2.2 due to docker
> container build issues. Will be interesting to see if it fails there. It did
> not fail the master nightly.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
