[ 
https://issues.apache.org/jira/browse/HBASE-24280?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17096202#comment-17096202
 ] 

Istvan Toth commented on HBASE-24280:
-------------------------------------

Depending on how important keeping the branch-2 and master POMs similar, I'd 
try one of these on master:

- Drop the hadoop.profile stuff, and just move out the settings to the main 
build. Optionally leaving some dummy profiles for compatibility (though we do 
not and did not support activating them directly)
- Set <activeByDefault> on the hadoop3 profile, and ignore the value of the 
hadoop.profile property. Some enforcer rules could check and warn / fail if it 
is set to anything other than 3.0.

Both of these could be made to work with the same (previous) personality 
settings that we have now.

Using direct profile activation for compatibility profiles in any remotely 
user-friendly way has proven futile (we had a very similar issue of Phoenix 
recently), so I think that should be avoided.


> TestSecureRESTServer started failing in nightlies for Hadoop3
> -------------------------------------------------------------
>
>                 Key: HBASE-24280
>                 URL: https://issues.apache.org/jira/browse/HBASE-24280
>             Project: HBase
>          Issue Type: Bug
>            Reporter: Josh Elser
>            Assignee: Istvan Toth
>            Priority: Major
>             Fix For: 2.3.0
>
>         Attachments: HBASE-24280.master.001.patch, 
> TEST-org.apache.hadoop.hbase.rest.TestSecureRESTServer.xml
>
>
> [~ndimiduk] pointed out that, after this change went in, TestSecureRESTServer 
> started failing with Hadoop3 on branch-2.3
> https://builds.apache.org/job/HBase%20Nightly/job/branch-2.3/56/
> Of course, I ran this with 1.8.0_241 and Maven 3.6.33 and it passed :) {{mvn 
> clean package -Dtest=TestSecureRESTServer -Dhadoop.profile=3.0 
> -DfailIfNoTests=false}}
> FYI [~stoty] in case you can repro a failure and want to dig in. Feel free to 
> re-assign.
> It looks like we didn't have a nightly run of branch-2.2 due to docker 
> container build issues. Will be interesting to see if it fails there. It did 
> not fail the master nightly.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to