sharmaar12 commented on code in PR #7385:
URL: https://github.com/apache/hbase/pull/7385#discussion_r2472832182
##########
hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/CompactSplit.java:
##########
@@ -344,6 +345,11 @@ protected void requestCompactionInternal(HRegion region,
HStore store, String wh
return;
}
+ if (isReadOnlyEnabled()) {
+ LOG.info("Ignoring compaction request for " + region + ",because
read-only mode is on.");
+ return;
+ }
+
Review Comment:
We can use that approach but then one issue I can think of is that
`hbase.global.readonly.enabled` property is dynamically configurable using
update_all_config but is it true for `hbase.hstore.compaction.enabled` also?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
