wchevreuil commented on code in PR #7385:
URL: https://github.com/apache/hbase/pull/7385#discussion_r2502402778
##########
hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/CompactSplit.java:
##########
@@ -344,6 +345,11 @@ protected void requestCompactionInternal(HRegion region,
HStore store, String wh
return;
}
+ if (isReadOnlyEnabled()) {
+ LOG.info("Ignoring compaction request for " + region + ",because
read-only mode is on.");
+ return;
+ }
+
Review Comment:
> Be careful with switching the property directly. User might have
intentionally disabled it and you should not enable it when go from R/O -> R/W
mode. My approach seems safer to me.
Good point. Let's just do all checks inside `isCompactionsEnabled`, as
@anmolnar suggested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
