wchevreuil commented on code in PR #7385:
URL: https://github.com/apache/hbase/pull/7385#discussion_r2477978557
##########
hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/CompactSplit.java:
##########
@@ -344,6 +345,11 @@ protected void requestCompactionInternal(HRegion region,
HStore store, String wh
return;
}
+ if (isReadOnlyEnabled()) {
+ LOG.info("Ignoring compaction request for " + region + ",because
read-only mode is on.");
+ return;
+ }
+
Review Comment:
> hbase.hstore.compaction.enabled
The actual property name is `hbase.regionserver.compaction.enabled`.
Compaction is actual "switchable" via the Admin.compactionSwitch() method (we
also expose an hbase shell command for that). The CompactSplit thread itself
exposes a switchCompaction method which could be called on both RS startup and
the dynamic config handler for the `hbase.global.readonly.enabled` property.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
