anmolnar commented on code in PR #7385:
URL: https://github.com/apache/hbase/pull/7385#discussion_r2473601588
##########
hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/CompactSplit.java:
##########
@@ -344,6 +345,11 @@ protected void requestCompactionInternal(HRegion region,
HStore store, String wh
return;
}
+ if (isReadOnlyEnabled()) {
+ LOG.info("Ignoring compaction request for " + region + ",because
read-only mode is on.");
+ return;
+ }
+
Review Comment:
I like @wchevreuil 's idea.
How about adding the read-only check to the getter?
```java
public boolean isCompactionsEnabled() {
return compactionsEnabled && !isReadOnlyEnabled();
}
```
You don't need to dynamically change the compaction flag.
wdyt?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
