[
https://issues.apache.org/jira/browse/HBASE-4583?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13487414#comment-13487414
]
Gregory Chanan commented on HBASE-4583:
---------------------------------------
#1
{code}// only remove Puts that concurrent scanners cannot possibly see
(readpoint - 1){code}
the "readpoint -1" stuff is out of date I think.
#2 I'm fine with updateColumnValue if it's only used in tests and the tests
pass.
#3 I'll file some JIRAs for adding a test for append (similar to your test for
increment) and for doing what you have done here for checkAndPut. checkAndPut
should be simple because I don't think it upserts.
#4 We may also need to a test to check that append/increment properly wait for
all writes to complete. Your test, as best as I can tell, checks that the
upsert behaves properly with scanners, but the waiting for all writes to
complete is sort of a separate issue. Something like what I suggested over in
HBASE-7051:
current cell value is 10. Do a put of 15 and an increment by 1. Only
acceptable answers are 15 and 16, but without this patch, we can get 11.
Again, this can be handled in a separate JIRA.
#5 I'm fine with this for 0.96. What do you think about 0.94? JD makes a good
point that we are far along to have such a big change, but on the other hand,
atomic issues are pretty serious. Wondering what your thoughts are. I'd at
least want to do some of my own performance testing before putting it in 0.94.
> Integrate RWCC with Append and Increment operations
> ---------------------------------------------------
>
> Key: HBASE-4583
> URL: https://issues.apache.org/jira/browse/HBASE-4583
> Project: HBase
> Issue Type: Bug
> Reporter: Lars Hofhansl
> Assignee: Lars Hofhansl
> Fix For: 0.96.0
>
> Attachments: 4583-trunk-less-radical.txt,
> 4583-trunk-less-radical-v2.txt, 4583-trunk-less-radical-v3.txt,
> 4583-trunk-less-radical-v4.txt, 4583-trunk-less-radical-v5.txt,
> 4583-trunk-radical.txt, 4583-trunk-radical_v2.txt, 4583-trunk-v3.txt,
> 4583.txt, 4583-v2.txt, 4583-v3.txt, 4583-v4.txt
>
>
> Currently Increment and Append operations do not work with RWCC and hence a
> client could see the results of multiple such operation mixed in the same
> Get/Scan.
> The semantics might be a bit more interesting here as upsert adds and removes
> to and from the memstore.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
