[ 
https://issues.apache.org/jira/browse/HBASE-4583?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13487442#comment-13487442
 ] 

Lars Hofhansl commented on HBASE-4583:
--------------------------------------

#1 Yeah, old comment.
#2 Should refactor the tests to call Upsert on Store and Memstore directly 
rather than this - now defunct - method. The patch at least removes it from the 
public API on both cases.
#3 I should add a test for Append. Bit more tricky than Increment as you get 
ever increasing values (in terms of size) 
#4 the test validates that. TestAtomicOperation would not return correct 
results without the Increments waiting for all previous changes. (before this 
patch this was handled by forcing the memTSs of all KV to 0 immediately)
#5 I'm fine either here, actually. Definitely 0.96, +0 on 0.94.

                
> Integrate RWCC with Append and Increment operations
> ---------------------------------------------------
>
>                 Key: HBASE-4583
>                 URL: https://issues.apache.org/jira/browse/HBASE-4583
>             Project: HBase
>          Issue Type: Bug
>            Reporter: Lars Hofhansl
>            Assignee: Lars Hofhansl
>             Fix For: 0.96.0
>
>         Attachments: 4583-trunk-less-radical.txt, 
> 4583-trunk-less-radical-v2.txt, 4583-trunk-less-radical-v3.txt, 
> 4583-trunk-less-radical-v4.txt, 4583-trunk-less-radical-v5.txt, 
> 4583-trunk-radical.txt, 4583-trunk-radical_v2.txt, 4583-trunk-v3.txt, 
> 4583.txt, 4583-v2.txt, 4583-v3.txt, 4583-v4.txt
>
>
> Currently Increment and Append operations do not work with RWCC and hence a 
> client could see the results of multiple such operation mixed in the same 
> Get/Scan.
> The semantics might be a bit more interesting here as upsert adds and removes 
> to and from the memstore.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to