Copilot commented on code in PR #2980:
URL: https://github.com/apache/hugegraph/pull/2980#discussion_r3004826678
##########
hugegraph-store/hg-store-dist/src/assembly/static/conf/log4j2.xml:
##########
@@ -117,6 +117,7 @@
<loggers>
<root level="INFO">
+ <appender-ref ref="console"/>
<appender-ref ref="file"/>
</root>
Review Comment:
Adding the console appender to the root logger won’t make logs from loggers
with additivity="false" appear in `docker logs`. In this config,
`com.alipay.sofa` (and other explicitly configured loggers) only write to
`raft_file`/`file`, so raft/third‑party logs will still be missing from stdout.
Consider also adding a `console` appender-ref to those additivity=false loggers
(or revisiting additivity) to fully achieve the Docker logging goal.
##########
hugegraph-pd/hg-pd-dist/src/assembly/static/conf/log4j2.xml:
##########
@@ -115,6 +115,7 @@
<loggers>
<root level="INFO">
+ <appender-ref ref="console" />
<appender-ref ref="file" />
</root>
Review Comment:
As with the other dist configs, adding `console` to `<root>` won’t surface
logs from any `additivity="false"` loggers that only write to
`raft_file`/`file`. If the goal is comprehensive `docker logs` output, consider
also wiring `console` into those additivity=false logger definitions (this
matches the wiring used in `hg-pd-service/src/main/resources/log4j2.xml`).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
