imbajin commented on code in PR #2980:
URL: https://github.com/apache/hugegraph/pull/2980#discussion_r3021303235
##########
hugegraph-server/hugegraph-dist/src/assembly/static/bin/start-hugegraph.sh:
##########
@@ -99,17 +99,14 @@ if [[ $PRELOAD == "true" ]]; then
sed -i -e '/registerBackends/d; /serverStarted/d'
"${SCRIPTS}/${EXAMPLE_SCRIPT}"
fi
-# TODO: show the output message in hugegraph-server.sh when start the server
if [[ $DAEMON == "true" ]]; then
echo "Starting HugeGraphServer in daemon mode..."
Review Comment:
‼️ The safer, lower-risk approach is to add an explicit switch for
Docker/stdout mode instead of removing `>> ${OUTPUT} 2>&1` from the default
startup path. That keeps the binary-package flow unchanged and still lets
containers stream clean logs via `docker logs` when the switch is
enabled.\n\n```text\nDefault package: start-*.sh -> exec java -> >> logs/*.log
2>&1\nDocker package: entrypoint -> set STDOUT_MODE=true -> exec java ->
stdout + console appender\n```\n\nI would keep the file-based behavior by
default, then enable stdout only in the Docker entrypoint and wire the console
appender in the matching log config.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
