imbajin commented on code in PR #2980:
URL: https://github.com/apache/hugegraph/pull/2980#discussion_r3021253313
##########
hugegraph-store/hg-store-dist/src/assembly/static/conf/log4j2.xml:
##########
@@ -117,6 +117,7 @@
<loggers>
<root level="INFO">
+ <appender-ref ref="console"/>
Review Comment:
‼️ Same issue in the store config: the root console appender does not cover
the `additivity="false"` logger blocks below, so `io.netty` /
`org.apache.commons` / `com.alipay.sofa` output is still invisible in `docker
logs`. If the goal is a complete container stream, those explicit loggers need
`console` as well.
##########
hugegraph-server/hugegraph-dist/src/assembly/static/conf/log4j2.xml:
##########
@@ -104,6 +104,7 @@
<loggers>
<root level="INFO">
+ <appender-ref ref="console"/>
<appender-ref ref="file"/>
</root>
Review Comment:
‼️ Adding `console` only to `root` and `org.apache.hugegraph` is not enough
here: the `additivity="false"` logger blocks below still bind only `file`, so
startup/runtime messages from `org.apache.cassandra`, `io.netty`,
`com.datastax.driver`, `com.alipay.sofa`, etc. will still be absent from
`docker logs`. Please attach `console` to the explicit logger blocks that
should be visible in containers.
##########
hugegraph-server/hugegraph-dist/src/assembly/static/bin/hugegraph-server.sh:
##########
@@ -184,5 +184,4 @@ fi
# Turn on security check
exec ${JAVA} -Dname="HugeGraphServer" ${JVM_OPTIONS} ${JAVA_OPTIONS} -cp
${CLASSPATH}: \
Review Comment:
‼️ Removing the launcher redirection here changes the default binary-package
flow too. In a plain install, JVM bootstrap stdout/stderr will no longer land
in the `logs/*.log` file, so the docs that tell users to inspect that file on
failure become incomplete. Please gate this on the Docker entrypoint path or
preserve the file sink outside containers.
##########
hugegraph-pd/hg-pd-dist/src/assembly/static/conf/log4j2.xml:
##########
@@ -115,6 +115,7 @@
<loggers>
<root level="INFO">
+ <appender-ref ref="console" />
<appender-ref ref="file" />
</root>
Review Comment:
‼️ The same completeness gap exists here too: `root` now has `console`, but
`com.alipay.sofa`, `io.netty`, and `org.apache.commons` still short-circuit to
`file` only because their logger blocks keep `additivity="false"`. Container
logs will still miss transport/startup output unless those explicit loggers
also opt into `console`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
