imbajin commented on code in PR #2980:
URL: https://github.com/apache/hugegraph/pull/2980#discussion_r3021303235
##########
hugegraph-server/hugegraph-dist/src/assembly/static/bin/start-hugegraph.sh:
##########
@@ -99,17 +99,14 @@ if [[ $PRELOAD == "true" ]]; then
sed -i -e '/registerBackends/d; /serverStarted/d'
"${SCRIPTS}/${EXAMPLE_SCRIPT}"
fi
-# TODO: show the output message in hugegraph-server.sh when start the server
if [[ $DAEMON == "true" ]]; then
echo "Starting HugeGraphServer in daemon mode..."
Review Comment:
‼️ 更稳妥、影响更小的做法是加一个显式开关来区分 Docker/stdout 模式，而不是直接把 `>> ${OUTPUT} 2>&1`
从默认启动路径里删掉。这样默认二进制包继续保持原来的文件落盘与排障体验，容器里再通过环境变量/参数切到 stdout，`docker logs`
才能拿到清晰输出。\n\n```text\n默认包: start-*.sh -> exec java -> >> logs/*.log
2>&1\nDocker包: entrypoint -> set STDOUT_MODE=true -> exec java -> stdout +
console appender\n```\n\n建议把这个开关先做成最小分支控制，再补齐 `log4j2.xml` 里的 console
绑定；这样能同时满足“容器可观测性”和“原有安装包不回归”。
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
