imbajin commented on code in PR #2980:
URL: https://github.com/apache/hugegraph/pull/2980#discussion_r3035071928
##########
docker/docker-compose.yml:
##########
@@ -41,6 +41,7 @@ services:
HG_PD_RAFT_PEERS_LIST: pd:8610
HG_PD_INITIAL_STORE_LIST: store:8500
HG_PD_DATA_PATH: /hugegraph-pd/pd_data
+ STDOUT_MODE: "true"
Review Comment:
❗️This line should be removed.
`STDOUT_MODE="true"` is already set in all three Dockerfiles, so keeping it
here creates a second source of truth in compose and increases config drift
risk.
Please delete this line directly in compose files (instead of keeping a
commented local override).
If you want compose-level control in the future, please centralize it with a
shared anchor and merge it into each service environment, for example:
```yaml
x-stdout-env: &stdout-env
STDOUT_MODE: "true"
services:
pd:
environment:
<<: *stdout-env
HG_PD_GRPC_HOST: pd
```
Please apply the same cleanup consistently in `docker/docker-compose.yml`,
`docker/docker-compose.dev.yml`, and
`docker/docker-compose-3pd-3store-3server.yml`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
