imbajin commented on code in PR #2980:
URL: https://github.com/apache/hugegraph/pull/2980#discussion_r3035071928
##########
docker/docker-compose.yml:
##########
@@ -41,6 +41,7 @@ services:
HG_PD_RAFT_PEERS_LIST: pd:8610
HG_PD_INITIAL_STORE_LIST: store:8500
HG_PD_DATA_PATH: /hugegraph-pd/pd_data
+ STDOUT_MODE: "true"
Review Comment:
⚠️ Since all three Dockerfiles now set `STDOUT_MODE="true"` by default, this
compose-level value is redundant and can drift over time. I suggest making
Dockerfile the single source of truth and keeping compose clean.
```suggestion
# STDOUT_MODE is provided by the image default (Dockerfile ENV).
# Uncomment only if you need a compose-level override:
# STDOUT_MODE: "true"
```
Please apply the same cleanup pattern in `docker/docker-compose.dev.yml` and
`docker/docker-compose-3pd-3store-3server.yml`.
If you prefer compose-level management later, please centralize it with one
shared anchor (e.g. `x-stdout-env`) and merge it into each service env, instead
of repeating the same literal value in multiple places.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
