Fokko opened a new pull request, #8675: URL: https://github.com/apache/iceberg/pull/8675
Found a regression that the snapshots are still around after the commit fails: https://github.com/trinodb/trino/pull/19188 ``` io.trino.plugin.iceberg.catalog.file.TestIcebergFileMetastoreCreateTableFailure.testCreateTableFailureMetadataCleanedUp; (took: 0.0 seconds) 2023-09-28T18:24:02.9837549Z java.lang.AssertionError: [Metadata file should not exist] 2023-09-28T18:24:02.9837847Z Expecting actual: 2023-09-28T18:24:02.9838206Z /tmp/test_iceberg_create_table_failure482309508502886299/test_create_failure_4huakfy1pd/metadata 2023-09-28T18:24:02.9838580Z to be an empty directory but it contained: 2023-09-28T18:24:02.9839258Z [/tmp/test_iceberg_create_table_failure482309508502886299/test_create_failure_4huakfy1pd/metadata/.snap-905595869249987831-1-7e5e14a9-79ec-449d-abf4-9cae0d693663.avro.crc, ``` This is a result of: https://github.com/apache/iceberg/pull/8599 It was actually enabled before, but now it is disabled. After the fix, I checked locally, the test passes: -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
