rdblue commented on PR #8675: URL: https://github.com/apache/iceberg/pull/8675#issuecomment-1740020616
I don't think this change is correct. The logic should continue to be to clean up if strict cleanup is not enabled. However, there is a behavior change here that is probably being hit by this test. We changed behavior and enabled strict cleanup for tables unless it is turned off by the catalog. This may leak files, but it is much safer and avoids table corruption on unknown exceptions. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
