aokolnychyi commented on code in PR #8675:
URL: https://github.com/apache/iceberg/pull/8675#discussion_r1340638771
##########
core/src/main/java/org/apache/iceberg/BaseTransaction.java:
##########
@@ -320,7 +320,7 @@ private void commitCreateTransaction() {
} catch (RuntimeException e) {
// the commit failed and no files were committed. clean up each update
- if (!ops.requireStrictCleanup() || e instanceof CleanableFailure) {
Review Comment:
I think the one that failed in Trino was testing `SchemaNotFoundException`
[here](https://github.com/trinodb/trino/blob/04cd049fbbc7f43ee827974650ae90d0b3357d19/plugin/trino-iceberg/src/test/java/io/trino/plugin/iceberg/catalog/file/TestIcebergFileMetastoreCreateTableFailure.java#L102).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
