aokolnychyi commented on code in PR #8675:
URL: https://github.com/apache/iceberg/pull/8675#discussion_r1340633607
##########
core/src/main/java/org/apache/iceberg/BaseTransaction.java:
##########
@@ -320,7 +320,7 @@ private void commitCreateTransaction() {
} catch (RuntimeException e) {
// the commit failed and no files were committed. clean up each update
- if (!ops.requireStrictCleanup() || e instanceof CleanableFailure) {
Review Comment:
Hm, isn't the existing logic correct? We should not clean up in strict mode
unless it is `CleanableFailure`? Is there a chance the test in Trino produced a
commit error that we treat as unknown?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
