huaxingao commented on code in PR #11827:
URL: https://github.com/apache/iceberg/pull/11827#discussion_r1892939462
##########
spark/v3.5/spark/src/test/java/org/apache/iceberg/spark/actions/TestRewritePositionDeleteFilesAction.java:
##########
@@ -310,7 +310,7 @@ public void testRewriteToSmallerTarget() throws Exception {
.option(SizeBasedFileRewriter.TARGET_FILE_SIZE_BYTES,
String.valueOf(avgSize / 2))
.execute();
List<DeleteFile> newDeleteFiles = deleteFiles(table);
- assertThat(newDeleteFiles).as("Should have 8 new delete files").hasSize(8);
+ assertThat(newDeleteFiles).as("Should have new delete files").hasSize(8);
Review Comment:
nit: Shall we unify the message and use `Expected new delete file(s)` as in
line 195?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
