TQJADE commented on code in PR #11827:
URL: https://github.com/apache/iceberg/pull/11827#discussion_r1893252492
##########
spark/v3.5/spark/src/test/java/org/apache/iceberg/spark/actions/TestRewritePositionDeleteFilesAction.java:
##########
@@ -380,7 +380,7 @@ public void testRemoveDanglingDeletes() throws Exception {
List<Object[]> actualRecords = records(table);
List<Object[]> actualDeletes = deleteRecords(table);
assertEquals("Rows must match", expectedRecords, actualRecords);
- assertThat(actualDeletes).as("Should be no new position
deletes").hasSize(0);
+ assertThat(actualDeletes).as("No new position deletes").isEmpty();
Review Comment:
Remove. I tried to mock a failure, by changing isEmpty to isNotEmpty. Here
is the messages with `No` started:
```
TestRewritePositionDeleteFilesAction > testRemoveDanglingDeletes() >
catalogName = testhive, implementation = org.apache.iceberg.spark.SparkCatalog,
config = {type=hive, default-namespace=default, cache-enabled=false},
fileFormat = PARQUET FAILED
java.lang.AssertionError: [No new position deletes]
Expecting actual not to be empty
at
org.apache.iceberg.spark.actions.TestRewritePositionDeleteFilesAction.testRemoveDanglingDeletes(TestRewritePositionDeleteFilesAction.java:383)
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
