szehon-ho commented on code in PR #11827:
URL: https://github.com/apache/iceberg/pull/11827#discussion_r1893228523
##########
spark/v3.5/spark/src/test/java/org/apache/iceberg/spark/actions/TestRewritePositionDeleteFilesAction.java:
##########
@@ -380,7 +380,7 @@ public void testRemoveDanglingDeletes() throws Exception {
List<Object[]> actualRecords = records(table);
List<Object[]> actualDeletes = deleteRecords(table);
assertEquals("Rows must match", expectedRecords, actualRecords);
- assertThat(actualDeletes).as("Should be no new position
deletes").hasSize(0);
+ assertThat(actualDeletes).as("No new position deletes").isEmpty();
Review Comment:
Do we need `no`? I wonder what the assert message is, maybe it will already
say 'expected new position deletes to be empty'
##########
spark/v3.5/spark/src/test/java/org/apache/iceberg/spark/actions/TestRewritePositionDeleteFilesAction.java:
##########
@@ -1054,48 +1054,48 @@ private void checkResult(
List<DeleteFile> newDeletes,
int expectedGroups) {
assertThat(rewrittenDeletes.size())
- .as("Expected rewritten delete file count does not match")
+ .as("Rewritten delete file count does not match")
Review Comment:
How about get rid of 'does not match, match', again in my thought, the
assert message will already say this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
