szehon-ho commented on code in PR #11827:
URL: https://github.com/apache/iceberg/pull/11827#discussion_r1892996768
##########
spark/v3.5/spark/src/test/java/org/apache/iceberg/spark/actions/TestRewritePositionDeleteFilesAction.java:
##########
@@ -453,7 +453,7 @@ public void testRewriteFilterRemoveDangling() throws
Exception {
.execute();
List<DeleteFile> newDeleteFiles = except(deleteFiles(table), deleteFiles);
- assertThat(newDeleteFiles).as("Should have 2 new delete files").hasSize(0);
+ assertThat(newDeleteFiles).as("Should have no new delete
files").hasSize(0);
Review Comment:
does isEmpty work for case where size = 0?
##########
spark/v3.5/spark/src/test/java/org/apache/iceberg/spark/actions/TestRewritePositionDeleteFilesAction.java:
##########
@@ -272,7 +272,7 @@ public void testRewriteFilter() throws Exception {
.execute();
List<DeleteFile> newDeleteFiles = except(deleteFiles(table), deleteFiles);
- assertThat(newDeleteFiles).as("Should have 4 delete files").hasSize(2);
+ assertThat(newDeleteFiles).as("Should have delete file(s)").hasSize(2);
Review Comment:
Same, can we remove language like 'should have'
##########
spark/v3.5/spark/src/test/java/org/apache/iceberg/spark/actions/TestRewritePositionDeleteFilesAction.java:
##########
@@ -192,7 +192,7 @@ public void testUnpartitioned() throws Exception {
.option(SizeBasedFileRewriter.REWRITE_ALL, "true")
.execute();
List<DeleteFile> newDeleteFiles = deleteFiles(table);
- assertThat(newDeleteFiles).as("Expected 1 new delete file").hasSize(1);
+ assertThat(newDeleteFiles).as("Expected new delete file(s)").hasSize(1);
Review Comment:
Can we remove language like 'expected'? I think assertThat already puts
that?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
