singhpk234 commented on code in PR #14767:
URL: https://github.com/apache/iceberg/pull/14767#discussion_r2684730183
##########
core/src/main/java/org/apache/iceberg/rest/RESTTableScan.java:
##########
@@ -169,6 +197,19 @@ private CloseableIterable<FileScanTask>
planTableScan(PlanTableScanRequest planT
}
}
+ private FileIO fileIOForPlanId(List<Credential> storageCredentials) {
+ return CatalogUtil.loadFileIO(
+ FILE_IO_IMPL,
Review Comment:
String ioImpl = properties.getOrDefault(CatalogProperties.FILE_IO_IMPL,
DEFAULT_FILE_IO_IMPL);
why resolvingFileIO always ?
##########
core/src/main/java/org/apache/iceberg/rest/RESTTableScan.java:
##########
@@ -216,6 +257,10 @@ private CloseableIterable<FileScanTask>
fetchPlanningResult() {
response.planStatus(),
planId);
+ if (null != planId && !response.credentials().isEmpty()) {
Review Comment:
nit: planId check is redundant
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
