singhpk234 commented on code in PR #14767:
URL: https://github.com/apache/iceberg/pull/14767#discussion_r2684852497
##########
core/src/main/java/org/apache/iceberg/rest/RESTTableScan.java:
##########
@@ -151,6 +175,21 @@ private CloseableIterable<FileScanTask>
planTableScan(PlanTableScanRequest planT
this.planId = response.planId();
PlanStatus planStatus = response.planStatus();
+ List<Credential> storageCredentials = response.credentials();
Review Comment:
> It's not like the server would have to keep additional state for such
"normal" table credentials if they aren't sub-scoped/tied to a particular
plan-Id
It may be tied, state need not be creds, it can be any plan related stuff,
lets say cache manifests and we wanna clean up the cached manifest from server,
when is the appropriate time ? we would remove it when query ends, but the
planning is already ended, in a hope table might be scanned again with similar
filter, server would like to know a optimistic time till when to cache it?
with that being said i believe if we have the context we should send context
back to the server, but I am ok to bring this up later and make progress in
this PR :), thank you for brainstorming with me
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
