smaheshwar-pltr commented on code in PR #17987:
URL: https://github.com/apache/iceberg/pull/17987#discussion_r3980237465
##########
spark/v3.5/spark/src/main/java/org/apache/iceberg/spark/actions/RewriteManifestsSparkAction.java:
##########
@@ -589,8 +590,10 @@ private PartitionSpec spec() {
return table().specs().get(specId);
}
- private OutputFile newOutputFile() {
- return table().io().newOutputFile(newManifestLocation());
+ private EncryptedOutputFile newOutputFile() {
+ Table table = table();
+ OutputFile rawOutputFile =
table.io().newOutputFile(newManifestLocation());
+ return table.encryption().encrypt(rawOutputFile);
Review Comment:
There actually aren't encryption tests for 3.5, not sure why. And thanks for
catching this!
I've added the test for this specific change in
https://github.com/apache/iceberg/pull/17987/commits/8b336a908ca138b4d778d2456f3697abd9cec421,
with a TODO to port remaining ones that I'm happy to tackle in an immediate
follow-up PR, if that works? I don't want to bloat this PR
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
