smaheshwar-pltr commented on code in PR #17987:
URL: https://github.com/apache/iceberg/pull/17987#discussion_r3957862724
##########
spark/v3.5/spark/src/main/java/org/apache/iceberg/spark/actions/RewriteManifestsSparkAction.java:
##########
@@ -589,8 +590,9 @@ private PartitionSpec spec() {
return table().specs().get(specId);
}
- private OutputFile newOutputFile() {
- return table().io().newOutputFile(newManifestLocation());
+ private EncryptedOutputFile newOutputFile() {
+ return EncryptingFileIO.combine(table().io(), table().encryption())
+ .newEncryptingOutputFile(newManifestLocation());
Review Comment:
But, the `OutputFileFactory` does actually do this more directly:
https://github.com/apache/iceberg/blob/af86b8399ca794bfe482eae85ba7e79ab0c49adc/core/src/main/java/org/apache/iceberg/io/OutputFileFactory.java#L119-L120
so I've since made the change to mirror that flow instead
##########
spark/v3.5/spark/src/main/java/org/apache/iceberg/spark/actions/RewriteManifestsSparkAction.java:
##########
@@ -589,8 +590,9 @@ private PartitionSpec spec() {
return table().specs().get(specId);
}
- private OutputFile newOutputFile() {
- return table().io().newOutputFile(newManifestLocation());
+ private EncryptedOutputFile newOutputFile() {
+ return EncryptingFileIO.combine(table().io(), table().encryption())
+ .newEncryptingOutputFile(newManifestLocation());
Review Comment:
But, the `OutputFileFactory` does actually do this more directly:
https://github.com/apache/iceberg/blob/af86b8399ca794bfe482eae85ba7e79ab0c49adc/core/src/main/java/org/apache/iceberg/io/OutputFileFactory.java#L119-L120
so I've since made the change to mirror that flow instead -
[741dd97](https://github.com/apache/iceberg/pull/17987/commits/741dd978f1c92995d41f604d4baaa401a7ac090b)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
