singhpk234 commented on code in PR #17987:
URL: https://github.com/apache/iceberg/pull/17987#discussion_r3954226743
##########
spark/v4.0/spark/src/test/java/org/apache/iceberg/spark/sql/TestTableEncryption.java:
##########
@@ -346,6 +349,40 @@ public void testManifestEncryption() throws IOException {
}
}
+ @TestTemplate
+ public void testRewriteManifestsEncryption() throws IOException {
Review Comment:
```suggestion
public void rewriteManifestsOnEncryptedTables() throws IOException {
```
##########
spark/v3.5/spark/src/main/java/org/apache/iceberg/spark/actions/RewriteManifestsSparkAction.java:
##########
@@ -589,8 +590,9 @@ private PartitionSpec spec() {
return table().specs().get(specId);
}
- private OutputFile newOutputFile() {
- return table().io().newOutputFile(newManifestLocation());
+ private EncryptedOutputFile newOutputFile() {
+ return EncryptingFileIO.combine(table().io(), table().encryption())
+ .newEncryptingOutputFile(newManifestLocation());
Review Comment:
do we need create new io per outputfile ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
