smaheshwar-pltr commented on code in PR #17987:
URL: https://github.com/apache/iceberg/pull/17987#discussion_r3957907385
##########
spark/v3.5/spark/src/main/java/org/apache/iceberg/spark/actions/RewriteManifestsSparkAction.java:
##########
@@ -589,8 +590,9 @@ private PartitionSpec spec() {
return table().specs().get(specId);
}
- private OutputFile newOutputFile() {
- return table().io().newOutputFile(newManifestLocation());
+ private EncryptedOutputFile newOutputFile() {
+ return EncryptingFileIO.combine(table().io(), table().encryption())
+ .newEncryptingOutputFile(newManifestLocation());
Review Comment:
I'm not too opinionated between the two, but I do think we should be
consistent with `SnapshotProducer` here in the code - so I've put up
https://github.com/apache/iceberg/pull/18014 in case we want to go in that
direction. LMKYT, cc @ggershinsky too but I think we can move forwards here 🙏
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
