RussellSpitzer commented on a change in pull request #2257:
URL: https://github.com/apache/iceberg/pull/2257#discussion_r583310743
##########
File path: core/src/test/java/org/apache/iceberg/TestSchemaAndMappingUpdate.java
##########
@@ -176,20 +176,11 @@ public void testModificationWithMetricsMetrics() {
.set("write.metadata.metrics.column.ids", "full")
.commit());
- AssertHelpers.assertThrows(
- "Deleting a column with metrics fails",
- ValidationException.class,
- null,
- () ->
- table.updateSchema()
- .deleteColumn("id")
- .commit());
+ // Re-naming a column with metrics succeeds;
+ table.updateSchema().renameColumn("id", "bloop").commit();
Review comment:
I think we may also want to validate that the metric config is copied to
the new name correctly, and deleted in the example below. Just to make sure the
same value goes through
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
