aokolnychyi commented on a change in pull request #2257:
URL: https://github.com/apache/iceberg/pull/2257#discussion_r588749829
##########
File path: core/src/main/java/org/apache/iceberg/MetricsConfig.java
##########
@@ -46,6 +47,35 @@ public static MetricsConfig getDefault() {
return spec;
}
+ public static Map<String, String> updateProperties(Map<String, String>
props, List<String> deletes,
+ Map<String, String>
renames) {
Review comment:
nit: I think `deletedColumns` and `renamedColumns` would be a bit
better. That's exactly the variable names we pass in from `SchemaUpdate`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
