aokolnychyi commented on a change in pull request #2257:
URL: https://github.com/apache/iceberg/pull/2257#discussion_r588765282
##########
File path: core/src/main/java/org/apache/iceberg/SchemaUpdate.java
##########
@@ -382,27 +378,43 @@ private int assignNewColumnId() {
}
private TableMetadata applyChangesToMapping(TableMetadata metadata) {
- String mappingJson =
metadata.property(TableProperties.DEFAULT_NAME_MAPPING, null);
Review comment:
Do we need to rename `mappingJson`? Seems like it is optional so may be
a good idea to avoid unnecessary changes to simplify cherry-picks and reviews.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
