aokolnychyi commented on a change in pull request #2257:
URL: https://github.com/apache/iceberg/pull/2257#discussion_r588764226
##########
File path: core/src/main/java/org/apache/iceberg/SchemaUpdate.java
##########
@@ -382,27 +378,43 @@ private int assignNewColumnId() {
}
private TableMetadata applyChangesToMapping(TableMetadata metadata) {
Review comment:
This method has a very specific name as it was previously only handling
updates to the name mapping. I think we should rename it into something more
generic now. What about just `applyChanges`?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
