nastra commented on a change in pull request #2826:
URL: https://github.com/apache/iceberg/pull/2826#discussion_r681842716
##########
File path: core/src/main/java/org/apache/iceberg/BaseTableScan.java
##########
@@ -306,6 +306,6 @@ private Schema lazyColumnProjection() {
}
private static String formatTimestampMillis(long millis) {
- return
DATE_FORMAT.format(LocalDateTime.ofInstant(Instant.ofEpochMilli(millis),
ZoneId.systemDefault()));
Review comment:
yes, this was an error reported from the newer error-prone checks
> com.palantir.baseline-error-prone uses a newer error-prone version (and
does additional checks), so a few changes were necessary to fix
JavaTimeSystemDefaultTimeZone / ConsistentOverrides errors
##########
File path: core/src/main/java/org/apache/iceberg/FindFiles.java
##########
@@ -103,7 +103,7 @@ public Builder asOfTime(long timestampMillis) {
// case, there is no valid snapshot to read.
Preconditions.checkArgument(lastSnapshotId != null,
"Cannot find a snapshot older than %s",
-
DATE_FORMAT.format(LocalDateTime.ofInstant(Instant.ofEpochMilli(timestampMillis),
ZoneId.systemDefault())));
Review comment:
yes, this was an error reported from the newer error-prone checks
> com.palantir.baseline-error-prone uses a newer error-prone version (and
does additional checks), so a few changes were necessary to fix
JavaTimeSystemDefaultTimeZone / ConsistentOverrides errors
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
