RussellSpitzer commented on a change in pull request #2826:
URL: https://github.com/apache/iceberg/pull/2826#discussion_r681823671
##########
File path: build.gradle
##########
@@ -570,15 +619,15 @@ if (jdkVersion == '8') {
tasks.jar.dependsOn tasks.shadowJar
dependencies {
- compile project(':iceberg-data')
- compile project(':iceberg-orc')
+ implementation project(':iceberg-data')
+ implementation project(':iceberg-orc')
testCompileOnly project(path: ':iceberg-data', configuration:
'testArtifacts')
testCompileOnly project(path: ':iceberg-orc', configuration:
'testArtifacts')
}
shadowJar {
- configurations = [project.configurations.compile,
project.configurations.compileOnly, project.configurations.testCompileOnly]
Review comment:
Why did this have a dependency on test compile deps ... that doesn't
sound right. The change makes sense here to me but just want to make sure we
know why it was this way before.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
