RussellSpitzer commented on a change in pull request #2826:
URL: https://github.com/apache/iceberg/pull/2826#discussion_r682853260
##########
File path: core/src/main/java/org/apache/iceberg/FindFiles.java
##########
@@ -103,7 +103,7 @@ public Builder asOfTime(long timestampMillis) {
// case, there is no valid snapshot to read.
Preconditions.checkArgument(lastSnapshotId != null,
"Cannot find a snapshot older than %s",
-
DATE_FORMAT.format(LocalDateTime.ofInstant(Instant.ofEpochMilli(timestampMillis),
ZoneId.systemDefault())));
Review comment:
could we just skip that rule? We do for some other error prone rules.
I'm fine with maybe making this change later just seems unrelated
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
