kbendick commented on code in PR #4943:
URL: https://github.com/apache/iceberg/pull/4943#discussion_r900331821
##########
flink/v1.15/flink/src/main/java/org/apache/iceberg/flink/source/ScanContext.java:
##########
@@ -82,6 +82,9 @@ public class ScanContext implements Serializable {
private static final ConfigOption<Boolean> INCLUDE_COLUMN_STATS =
ConfigOptions.key("include-column-stats").booleanType().defaultValue(false);
+ private static final ConfigOption<Integer> SNAPSHOT_GROUP_LIMIT =
+
ConfigOptions.key("snapshot-group-limit").intType().defaultValue(Integer.MAX_VALUE);
Review Comment:
+1 to this name. Config keys should ideally be concise as well as being as
short as possible and `max-planning-snapshot-count` achieves that.
The documentation can potentially use the language `Maximum number of
snapshots to consume and plan per group in each iteration of an incremental
scan` or something similar (might need to work on that language too but the
language from the other ideas can be used in the docs possibly).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
